-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated distutils.Version to packaging.Version #3897
Conversation
Looks like the CI failures were unrelated, although some time has passed and it would be good to rebase this I think. Any other reason to not merge it? If @hoxbro is not interested in pursuing this, I'll be happy to take over. |
46c8a85
to
944d6b1
Compare
This seems like an interesting PR but I'd like more information about what problems it solves and what risks it entails... What concrete problems are being experienced with the current code? Is the replacement a well-tested, drop-in replacement for the deprecated one, or are there caveats we need to be aware of and check? Why is the old thing being deprecated in favour of the new thing? |
Long story short, The "Migration Advice" section of PEP 632 lists |
Thanks for the explanation! So |
(I believe the build failure is indeed unrelated, or at least can be fixed elsewhere, so the only thing blocking a merge here is my understanding of the change :) |
Funny, They're not the same, but for the purposes that matter to us, they are. |
Lol! I do wonder if moving to something stricter might not cause some hard to diagnose breaking changes... Maybe migrating to something that claims to be compatible might be a better choice? Something like https://pypi.org/project/looseversion/ ? |
There's a tiny possibility of breaking changes, but for that to happen an invalid version of ipywidgets, matplotlib, or orca should reach the user environment, which is highly unlikely because PyPI disallowed invalid versions a long time ago. On the other hand, in the event of a breaking change, it wouldn't be hard to diagnose at all: a loud I see how adopting Either way, removing the |
OK. Thanks @astrojuanlu ! |
And thanks @hoxbro for the PR :) |
Hehe so I just realized that this PR modified auto-generated code... I'll need to modify the source of that code-gen process for these changes to stick: https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/codegen/__init__.py#L273 |
@astrojuanlu I didn't check on this earlier but... it seems like |
Ah it seems like older versions of |
That's right: pypa/packaging#500 I think pip will pick up the right version in this case |
Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
Fixes #3893