Skip to content

Conversation

icaromedeiros
Copy link
Contributor

Hello all,

The last line on the snippet shown below (that should be clear in the commit diff) is useless as the figure variable is not used in plot function.

plot_html, plotdivid, width, height = _plot_html(
  figure_or_data, show_link, link_text, validate, '100%', '100%'
)

figure = tools.return_figure_from_figure_or_data(figure_or_data, validate)

Moreover, the same call to tools.return_figure_from_figure_or_data is done within _plot_html.
It seems this is left-out garbage in the code.

A simple pep8/flake8 integration on the tests could solve similar issues.

@ispmarin
Copy link

👍

@jackparmer
Copy link
Contributor

+1 Thanks!

jackparmer added a commit that referenced this pull request Feb 23, 2016
Remove useless line in offline plot function
@jackparmer jackparmer merged commit 0dded42 into plotly:master Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants