px.line: don't use webgl if line_shape="spline" is given #4305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for documentation for plotly.express.line seems to imply that when calling
px.line
,line_shape
can be given as"linear"
or"spline"
without any other limitations. However, if one calls it withrender_mode="auto"
(or without providingrender_mode
, as"auto"
is its default value) and with a large enough dataframe (over 1000 total plotted entries),line_shape="spline"
causes an error. This error is caused by the webgl render mode (go.Scattergl
) being used by default with large dataframes instead of the svg render mode (go.Scatter
). This PR works around this issue by not defaulting to the webgl render mode isline_shape="spline"
is given, as the documentation implies that this should work. It's worth noting that this will likely incur a performance penalty, but I think that anyone rendering that much data is willing to accept the hit :)This should address #2812
Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).