added the option for multiple binsizes #455
Conversation
|
Also have to fix backwards compatibility, because old examples use single floats and not arrays |
|
@theengineear Hi Andrew, Is it possible for you to take a look at this PR while Chelsea is away? |
|
Yep. Sure can :). I'll get to it today. |
| -0.5, 0.3, 0.4, -0.37, 0.6] | ||
| hist2_x = [0.8, 1.5, 1.5, 0.6, 0.59, | ||
| 1.0, 0.8, 1.7, 0.5, 0.8, | ||
| -0.3, 1.2, 0.56, 0.3, 2.2] |
There was a problem hiding this comment.
🐄 any reason to wrap these lists before the 79 character line length limit?
There was a problem hiding this comment.
Oh no reason, I just copy&pasted that data from another distplot test. Though I can definitely save a line by following that tip.
|
Awesome! Couple of comments for ya! Let me know if you have any questions and ping me when you're ready for another review. |
|
@theengineear Should be good to go! |
|
@yankev great! Nice work! Just address #455 (comment) and after you've done that 💃 ! Merge away. |
|
@theengineear k added! Thanks for the help! |
@cldougl
Probably need to write a test.