Skip to content

make sure colorbar points are lists of first point and update test #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2016

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Aug 25, 2016

No description provided.

@Kully
Copy link
Contributor Author

Kully commented Aug 25, 2016

@theengineear

@Kully
Copy link
Contributor Author

Kully commented Aug 25, 2016

@theengineear So Emilia pointed out that the colorbar I added to the trisurfs doesn't appear when online is enabled. I have fixed this by switching the x[0] to a x[0:1] so as to make sure x receives a list

z=z[0],
x=x[0:1],
y=y[0:1],
z=z[0:1],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐄 z[:1] works too, fwiw.

@theengineear
Copy link
Contributor

💃

@Kully
Copy link
Contributor Author

Kully commented Aug 25, 2016

💃

Excellent! Shall I update v. num?

@theengineear
Copy link
Contributor

Yah, good call :)

@Kully
Copy link
Contributor Author

Kully commented Aug 25, 2016

Yah, good call :)

Okay, will get to it tomorrow most lik

@Kully
Copy link
Contributor Author

Kully commented Aug 26, 2016

@theengineear Do you mind looking at this failing test when you have a moment? It looks like a proper image is not being produced but the only error after nosetests on my end is the one you said was because my matplotlib version is unsupported:

FAIL: plotly.tests.test_optional.test_matplotlylib.test_subplots.test_blank_subplots
----------------------------------------------------------------------
Traceback (most recent call last):
  File "//anaconda/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/adamkulidjian/Desktop/Adam/Plotly/plotly.py/plotly/tests/test_optional/test_matplotlylib/test_subplots.py", line 37, in test_blank_subplots
    assert equivalent, msg
AssertionError: ['yaxis1']['range'] = [0.80000000000000004, 2.0] should be [1.0, 2.2]

It failed this way for Python 2 and 3

@Kully
Copy link
Contributor Author

Kully commented Aug 26, 2016

Do you mind looking at this failing test when you have a moment?

Nevermind, tests passed!

@Kully Kully merged commit da847bd into master Aug 26, 2016
@Kully Kully deleted the trisurf-colorbar-visible branch August 26, 2016 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants