[2.0.0] Relocate figure factory #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old location is now deprecated.
Ok the changes in default args are more than style changes… Just a heads up.
theengineear
force-pushed
the
relocate-figure-factory
branch
from
37c9566 to
bcb6da0
Compare
|
💃 Really good organization. |
|
@chriddyp gonna go ahead and merge this, it deprecates-but-doesn't-break FF stuff and I don't want to drag the process out too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a lot of circular dependency stuff for us. It also puts an end to the ~8000 line file that is
tools.py... that's ridiculous.The new imports work like this:
from plotly.figure_factory import create_scatterplotmatrix... etc, etc.