v2.0.8 only write config file if changed #734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having an issue of plotly credentials occasionally deleted for some of the users. I was not able to produce the bug consistently. It seems that the credentials are overwritten once concurrency comes in place.
The .credentials and .config files are open many times for writing (+w), every time the ensure_local_plotly_files (https://github.com/plotly/plotly.py/blob/master/plotly/tools.py#L77) is called, and it is called every time plotly is used.
This fix will only overwrite (or open for writing) the configuration files, if the configuration keys change, but not every time when plotly is called. Once the correct config is present, those files won't be open for writing anymore, and hence won't be overwritten due to exceptions caused by system file locks and such, which can happen in case of concurrency.