[wip] - ipyplotly fixes #956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New codegen logic in codegen/ New datatype classes generated into plotly/datatypes/ (These are gitignored) New validator classes generated into plotly/validators/ (These are gitignored) Code generation in update_graph_objs.py modified to map Figure, Layout, and Trace types to new plotly/datatypes/ classes. All other classes mapped to raw dicts/lists.
It's now possible to execute a fair amount of legacy graph construction and plotting code
TODO: add support for datetime arrays in validation and in widget serialization
Added js/ directory containing front-end widget library Added graph_objs.FigureWidget class that maps to datatypes.FigureWidget
These are mostly just for discussion during the WIP integration process.
we’ll end up adding a lot of this stuff back at the end. for now, let’s just only test python 35
use same versions as what is specified in `optional`. ultimately, we’ll want to remove these and only include them for the ‘build’ environment
|
Test Results |
|
With error messages: |
|
Summary of test failures:
|
|
@chriddyp I started looking at the subplot properties ending in 1 errors (e.g. Here is the JSON schema snippet for These regular expressions exclude anchor strings like I haven't dug into the current Python logic or the Plotly.js handling, but do you think Plotly.js accepts anchors like |
|
Testing issues:
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working off of #942