Impl Color for f64 (+ f32, i64, i32, ...) #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I noticed that someone had raised an issue regarding the removal of
impl Color for f64in a previous version (#141). I also had this issue and to be honest, I don't even know how one would use the colorscales with a scatter plot without being able to use a reference vector.I went ahead and created a very simple pull request to reimplement it, along with
impl Colorfor other types (f32,i64,i32, ...).Additionally, I expanded the 3d_charts example to include a plot that showcases the now working colorscales.
I also fixed the
customized_scatter3d_plot()where colorscales were not working because of this.If there is any reason why this wouldn't just work like this please let me know.