Add a method to render the plot to anything implementing Write #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plotly supported rendering the plot to HTML, and writing the output to a file, located at a user given path. Often however, it's desirable to split the process of rendering and the process of outputting the rendering. In addition, writing to a path is not always the most flexible, since you don't always have a file path. It can then be useful to be able to write the rendered entity to any writable buffer, which can be accomplished by using the std::io::Write trait instead of a path, which is what this change set does.
foresterre
changed the title
foresterre
changed the title
|
Follow up to #40, now against the (hopefully 😄 ) correct branch. |
|
Thanks for the update @foresterre; will have a closer look this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotly supported rendering the plot to HTML, and writing the output to a file, located at a user given path. Often however, it's desirable to split the process of rendering and the process of outputting the rendering. In addition, writing to a path is not always the most flexible, since you don't always have a file path. It can then be useful to be able to write the rendered entity to any writable buffer, which can be accomplished by using the std::io::Write trait instead of a path, which is what this change set does.
If desirable, I can also rework it to support the other output formats.