add sharing parameter for saveplotlyconfig #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yankev looks good. Did you test this with various settings / does it update + validate properly? |
| @@ -1,4 +1,4 @@ | |||
| function saveplotlyconfig(plotly_domain,plotly_streaming_domain) | |||
| function saveplotlyconfig(plotly_domain,plotly_streaming_domain, sharing) | |||
There was a problem hiding this comment.
should we make the spacing here consistent too? just for looks 👗
|
Yep I tried a couple variations, and it seems to validate and update correctly. Only issue would be that if validation fails then the config file just be empty. We could keep this behaviour, or change the error to a warning, which would allow the other parameters to be written |
|
@yankev good point - could you make https://github.com/plotly/MATLAB-api/pull/104/files#diff-1a55e631c9c6db6c4e1372e0d2cc6f85R67 a simple warning instead of failing to save everything. |
|
cool - 💃 from me. |
|
👍 I'll get the doc edit when you merge this @yankev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #103.
@BRONSOLO