Changed PlotOptions.Strip to false #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshpurwar what is this PR intended to do? If there is a GitHub issue that it is fixing, can you please link it here? |
Done! |
|
This PR also fixes issue #209 |
jackparmer
approved these changes
Jul 29, 2021
|
excellent find. works for me. 💃 |
jackparmer
requested review from
gilbertogalvis and
VolKa79
and removed request for
jolinos and
uzairmughal110
|
Noe this also resolves issue #211 |
This was
linked to
issues
Jul 29, 2021
VolKa79
approved these changes
Jul 29, 2021
This was
linked to
issues
Jul 29, 2021
xarico10
approved these changes
Jul 30, 2021
xarico10
approved these changes
Jul 30, 2021
gilbertogalvis
approved these changes
Jul 30, 2021
xarico10
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue #210 thus, the branch name!
bargroupgapis correctly written out in theobj.layoutin updatebar.m, but I think this gets stripped off eventually and so we don't get the correct bar width in the online plots. Turning off stripping for the plot options fixes this bug and possibly many others!