Line/scatter/area plot editor #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on getting this merged so that it can be used. I don't think there were breaking changes beyond needing to hook up both the initialization and update events to the plot. That's done in the example code here.
If you're using the hub from the example repo that hooks up all the pieces, that will also need to be updated. I think this hub should get moved into an export of the editor so that it can be imported seamlessly, but I haven't yet done that. At any rate, that should be an easy migration.
Usage of the
plotly.js-react
component has also changed just slightly. Specifically:Other than that, I'm going to go over this a bit more and make sure everything can be expected to work out of the box. Once that's done, I'll merge this and notify that it's ready to go. The plan is to:
cc @ereplogle @alteryx-grose @alteryx-sezell @alteryx-smann @alteryx-vsmith @alexcjohnson @jackparmer