subplots panel initial #610

dmt0 · 2018-07-26T00:14:59Z

Subplots panel - in dev

Known issues / TODO:

rectangle needs to be positioned correctly - no making it 3px doesn't work
DualNumeric is a hack - needs to be done right
possibly merge AxesCreator and SubplotCreator - at least partially - lots of ways to improve the code - some utility functions for figuring out subplot names would be useful - raised Refactor: merge AxesCreator and SubplotCreator #631
move geo., scene. stuff into subplot panel OR create some SubpotConnectedSections in GraphCreatePanel

addresses #580

nicolaskruchten · 2018-07-26T02:12:31Z

Dude this is sweet!

dmt0 · 2018-07-26T02:40:20Z

:)
I'm thinking, shouldn't we just move all that into GraphCreatePanel into the trace folds? The only drawback I see is that if two traces are on the same subplot, their controls will be mirroring each other.

nicolaskruchten · 2018-08-04T00:37:05Z

So cool! non-cartesian appears broken, and dragging is broken in snap mode, but so cool!

nicolaskruchten · 2018-08-06T15:02:23Z

In AxesCreator you'll need to update the text to say that you can edit the subplots in the right panel. now it says "axes"

nicolaskruchten · 2018-08-06T15:02:46Z

VeraZab · 2018-08-06T15:17:48Z

src/components/fields/derived.js

-      plotProps.fullContainer._subplot &&
-      plotProps.fullContainer._subplot.includes('xaxis')
-    ) {
+    if (props.attr.startsWith('x')) {


this seems a little fragile, is there a way to make it more precise?
what if there's other axes related attributes that start with x or y..

good call, i'll make it more precise
but generally, this guys get attr supplied to them

nicolaskruchten · 2018-08-06T15:23:15Z

src/DefaultEditor.js

 import {
  GraphCreatePanel,
  GraphTransformsPanel,
+  StyleSubplotsPanel,


nicolaskruchten · 2018-08-06T15:24:27Z

src/default_panels/StyleAxesPanel.js

          <ColorPicker label={_('Font Color')} attr="titlefont.color" />
        </AxesFold>

-        <AxesFold


Yeah! goodbye Layout Panel! You won't be missed :)

VeraZab · 2018-08-06T15:38:40Z

package.json

+    "react-resizable-rotatable-draggable": "^0.1.8",
    "react-select": "^1.2.0",
    "react-tabs": "^2.2.1",
+    "styled-components": "^3.3.3",


are we actually using it?

it's a peer dep of the draggy thing.

VeraZab · 2018-08-06T16:34:24Z

src/components/containers/SubplotAccordion.js

+        ))
+    );
+
+    Object.keys(layout).forEach(layoutKey => {


I found it confusing here as to why we were looping through layout, not fullLayout.
And why we were using data.findIndex instead of maybe filter to find all indexes that could meet the condition.

If you could maybe comment above on those 2 questions, I think it may help in a few months time, when revisiting that code.

VeraZab · 2018-08-06T16:53:33Z

src/components/fields/RectanglePositioner.js

+                key={i}
+                className="rect-grid"
+                style={{
+                  width: fieldWidthPx / gridRes - 1,


could we move this to a style sheet for the ones we can?

not really, if you see the math we're doing here, it doesn't really map well onto a stylesheet

I suppose we could create classes for the various grid-box-types but there are 9 of them (4 corners, 4 faces, inside) which would be messier than just building them up from stratch like this IMO. Although with faaaancy CSS3 selectors you might be able to do it ;)

VeraZab · 2018-08-06T17:09:44Z

awesome job guys !! 👍
If @dmt0 you could just leave me a comment in SubplotAccordion of what the json looks like in a situation where we have 2 subplots of either ['geo', 'mapbox', 'polar', 'gl3d', 'ternary'], I'm 💃 on this pr.

nicolaskruchten · 2018-08-06T17:30:14Z

💃

dmt0 requested a review from nicolaskruchten July 26, 2018 00:15

dmt0 force-pushed the subplots branch 13 times, most recently from 0ff1eb6 to 3b728af Compare August 3, 2018 22:44

dmt0 force-pushed the subplots branch 8 times, most recently from 653ff58 to 40c5e1a Compare August 6, 2018 14:53

dmt0 changed the title ~~subplots panel initial - in Dev~~ subplots panel initial Aug 6, 2018

dmt0 force-pushed the subplots branch from 40c5e1a to c31dd4b Compare August 6, 2018 15:04

VeraZab reviewed Aug 6, 2018

View reviewed changes

nicolaskruchten reviewed Aug 6, 2018

View reviewed changes

src/DefaultEditor.js Outdated

import {

GraphCreatePanel,

GraphTransformsPanel,

StyleSubplotsPanel,

Copy link

Contributor

nicolaskruchten Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename?

nicolaskruchten reviewed Aug 6, 2018

View reviewed changes

dmt0 force-pushed the subplots branch 2 times, most recently from 041aeec to 90abf62 Compare August 6, 2018 15:34

dmt0 and others added 9 commits August 6, 2018 11:35

subplots panel initial

76c22fd

prototype rectangle positioner

b1e0e4b

grid-snap

6259573

rectangle positioner for cartesian

0a5ea61

fix for Axes to Use section appearing randomly

00ebb3a

axis creation for combinations of different cartesian traces

0e2e760

widgets for multiple subplots for non-cartesian traces

74f4593

cartesian axes - not swapping and garbage collection

9399c48

garbage-collect axes/subplot on trace deletion

3aabee2

dmt0 force-pushed the subplots branch from 90abf62 to b893b5a Compare August 6, 2018 15:35

VeraZab reviewed Aug 6, 2018

View reviewed changes

dmt0 added 2 commits August 6, 2018 11:43

move overlaying, etc to subplots panel

0944218

improve RectanglePositioner

e17d153

dmt0 force-pushed the subplots branch from b893b5a to 859f0f4 Compare August 6, 2018 15:45

dmt0 mentioned this pull request Aug 6, 2018

Subplots for all trace types #580

Closed

VeraZab reviewed Aug 6, 2018

View reviewed changes

dmt0 and others added 2 commits August 6, 2018 13:22

minor refactor

758e07b

fix styling bugs

480f766

dmt0 force-pushed the subplots branch from fd75011 to 480f766 Compare August 6, 2018 17:22

dmt0 merged commit 975ea1b into master Aug 6, 2018

dmt0 deleted the subplots branch August 6, 2018 17:43

Uh oh!

subplots panel initial #610

subplots panel initial #610

Uh oh!

Conversation

dmt0 commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolaskruchten commented Jul 26, 2018

Uh oh!

dmt0 commented Jul 26, 2018

Uh oh!

nicolaskruchten commented Aug 4, 2018

Uh oh!

nicolaskruchten commented Aug 6, 2018

Uh oh!

nicolaskruchten commented Aug 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VeraZab Aug 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VeraZab commented Aug 6, 2018

Uh oh!

nicolaskruchten commented Aug 6, 2018

Uh oh!

Uh oh!

dmt0 commented Jul 26, 2018 •

edited

Loading

VeraZab Aug 6, 2018 •

edited

Loading