color picker inline #642
Merged
color picker inline #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmt0
force-pushed
the
colorpicker-nopopover
branch
from
a6e7a89 to
74a2cf4
Compare
dmt0
force-pushed
the
colorpicker-nopopover
branch
3 times, most recently
from
1999661 to
2a60508
Compare
|
in Percy's |
|
there seems to be less space.. does this still look ok with an open colorscalepicker? |
|
A more minimalistic picker, nice, I like! |
|
@VeraZab yeah, this is because it's a fold in a fold and the color pickers are now fixed-width. I think we should accept this one for now :) |
|
ok well codewise looks ok to me otherwise 💃 |
|
Issue for misaligned colorpickers raised: |
dmt0
force-pushed
the
colorpicker-nopopover
branch
from
2dd253f to
f8a7cad
Compare
|
💃 from me, including the Percy diffs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #626