Panel tweaks #694
Merged
Panel tweaks #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmt0
reviewed
Aug 15, 2018
| {label: _('Center'), value: 'center'}, | ||
| {label: _('Right'), value: 'right'}, | ||
| ]} | ||
| /> |
There was a problem hiding this comment.
I think it needs to be clearable={false}, same for other 3 dropdowns.
|
Ok, could you plz make that change and merge? That way it gets into a daily
build sooner :)
…On Tue, Aug 14, 2018 at 20:45 Dmitry Shvedov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/default_panels/StyleSlidersPanel.js
<#694 (comment)>
:
> + {label: _('Fraction of canvas'), value: 'fraction'},
+ {label: _('Pixels'), value: 'pixels'},
+ ]}
+ />
+ </PlotlySection>
+ <PlotlySection name={_('Horizontal Positioning')} attr={'x'}>
+ <Numeric label={_('Position')} attr={'x'} showSlider step={0.02} />
+ <Dropdown
+ label={_('Anchor')}
+ attr={'xanchor'}
+ options={[
+ {label: _('Left'), value: 'left'},
+ {label: _('Center'), value: 'center'},
+ {label: _('Right'), value: 'right'},
+ ]}
+ />
other than that 💃
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#694 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbA2QcWRo-3wZvhbjO_Udm50zG2vNlks5uQ5lPgaJpZM4V9WeR>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new pass on Sliders and Menus, adding some basic positioning widgets and fixing a crash when hiding a menu.