Skip to content

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Aug 28, 2018

PlotlyEditor can receive a prop chartHelp of type object that looks like

{
  area: {helpDoc: 'https://someurl/', examplePlot: () => {}, feedQuery: 'area'},
  bar: {helpDoc: 'https://someurl/', examplePlot: () => {}, feedQuery: 'bar'},
  ...
}

If the prop exists, examples, tutorials, and links to community examples show up in Trace Selector.

Example is a callback that is meant to update the figure.

Also had to downgrade packages, because npm run make:lib:cs was producing errors - there were some unparced SASS variables. cssnano particularly changed a lot going into v4.

@nicolaskruchten
Copy link
Contributor

Can you add some examples of this into the dev app plz?

@dmt0 dmt0 force-pushed the trace-examples branch 4 times, most recently from 3f27b18 to ffbb871 Compare August 28, 2018 22:27
@dmt0 dmt0 merged commit 8b7059d into master Aug 30, 2018
@dmt0 dmt0 deleted the trace-examples branch August 30, 2018 19:04
))
? actionItems(item).map(
(action, i) =>
!action.onClick ? null : (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could just be action.onClick && x instead of !action.onClick ? null : x. Not a big deal but it jumped out at me for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants