Hot fix add trace #780
Merged
Hot fix add trace #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
force-pushed
the
hot-fix-add-trace
branch
from
24d3537 to
6407d23
Compare
|
@dmt0 please review |
|
💃 |
|
How does prevtrace not have a type?? Or not exist? |
|
I guess if pushed via api and relying on default type=scatter |
src/lib/customTraceType.js
Outdated
| }; | ||
| default: | ||
| return {type: traceType}; | ||
| return {type: traceType ? traceType : 'scatter'}; |
There was a problem hiding this comment.
This is actually problematic
There was a problem hiding this comment.
The scatter case should set the same options as at the top otherwise there are two “scatter” paths
|
Dancer only when scatter path is centralized :) |
|
💃 looks good to me now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://github.com/plotly/streambed/issues/11752