sortMenu adjustments #797
Merged
sortMenu adjustments #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
force-pushed
the
adjust-panels-sort
branch
2 times, most recently
from
f28442a to
d4e12e5
Compare
src/components/PanelMenuWrapper.js
Outdated
| const groupLookup = {}; | ||
| let groupIndex; | ||
| const panels = React.Children.toArray(children); | ||
| let childrenArray = React.Children.toArray(children); |
There was a problem hiding this comment.
could be a ternary... let's try to avoid using let as much as we can please in new code :)
There was a problem hiding this comment.
in fact, let's go one more step: just always call sortMenu and if menuPanelOrder is null just early-return. much easier to read.
|
|
||
| describe('sortMenu', () => { | ||
| it('modifies original array to follow the group, then name order provided', () => { | ||
| it('returns a new array of sorted children', () => { |
There was a problem hiding this comment.
yes! much more functional :)
Modifying things in-place is almost always a bad idea
|
💃 as-is, but if you want to do my stylistic changes that's fine too :) |
VeraZab
force-pushed
the
adjust-panels-sort
branch
from
d4e12e5 to
711084c
Compare
|
Tests were failing due to an intermittent CI failure, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on streambed this time, gives desired result.
@nicolaskruchten @dmt0 please review