Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize handler not removed when fit property is true #24

Closed
ryanthomasnz opened this issue Dec 13, 2017 · 2 comments
Closed

Resize handler not removed when fit property is true #24

ryanthomasnz opened this issue Dec 13, 2017 · 2 comments
Assignees
@nicolaskruchten

Comments

@ryanthomasnz
Copy link

When a Plotly-React plot is removed from page (props.fit is true) the following error occurs when resizing the window:

Uncaught TypeError: Cannot read property 'parentElement' of null
    at PlotlyComponent.getParentSize (factory.js:251)
    at PlotlyComponent.getSize (factory.js:264)
    at resizeHandler (factory.js:195)
getParentSize @ factory.js:251
getSize @ factory.js:264
resizeHandler @ factory.js:195
@bpostlethwaite
Copy link
Member

Thanks for the report @ryanthomasnz . We'll get back to you sometime in early-mid January.

@nicolaskruchten nicolaskruchten self-assigned this Jan 10, 2018
nicolaskruchten added a commit that referenced this issue Jan 23, 2018
@nicolaskruchten
fix for #24 and omission from last release
075170b
nicolaskruchten added a commit that referenced this issue Jan 23, 2018
@nicolaskruchten
fix for #24 and omission from last release
765fe5c
@nicolaskruchten
Copy link
Member

This is fixed in the latest release, 1.3.0... Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaskruchten nicolaskruchten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolaskruchten @bpostlethwaite @ryanthomasnz