Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish #5

Closed
rreusser opened this issue Oct 5, 2017 · 1 comment
Closed

Publish #5

rreusser opened this issue Oct 5, 2017 · 1 comment

Comments

@rreusser
Copy link
Contributor

rreusser commented Oct 5, 2017

This will soon be published. Here are the choices:

  1. A single module will export both the version with plotly and as a factory.

    import PlotComponent from 'react-plotly.js'

    Or, alternatively,

    import Plotly from 'plotly.js'
    const EquivalentPlotComponent = factory(Plotly)

    This means plotly.js will be a peer dependency of react-plotly.js. I learned today that peer dependencies are optional and just give a warning if not found. So the usage will either be that you import the factory and create your own, based on your own version of plotly, or that you import the component and it's up to you to npm install plotly.js so that it's available.
    See also:

  2. Description will be A Plotly.js react component from Plotly.

/cc @bpostlethwaite @etpinard @monfera @nicolaskruchten

@rreusser
Copy link
Contributor Author

Have made and implemented these decisions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant