Skip to content

specify react version for linter #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2018
Merged

specify react version for linter #113

merged 2 commits into from
Nov 22, 2018

Conversation

antoinerg
Copy link
Contributor

Fixes #112

@nicolaskruchten
Copy link
Contributor

I'm ok with this in principle but I have no idea what it does, can you explain plz? :)

@antoinerg
Copy link
Contributor Author

I simply used the default configuration as suggested on eslint-plugin-react (https://github.com/yannickcr/eslint-plugin-react#configuration). It turns out that every settings I specified were default values except for react.version. I removed the default ones in commit a465275.

@nicolaskruchten
Copy link
Contributor

💃

@antoinerg antoinerg merged commit cdd1bad into master Nov 22, 2018
@antoinerg antoinerg deleted the 112-fix-test branch November 22, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinerg @nicolaskruchten