Add onPurge callback #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Dec 30, 2017
| import React, {Component} from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import isNumeric from 'fast-isnumeric'; | ||
| import objectAssign from 'object-assign'; | ||
| // import throttle from "throttle-debounce/throttle"; | ||
|
|
There was a problem hiding this comment.
can we delete this commented out import
There was a problem hiding this comment.
agreed though I'll let the future maintainer do it. Maybe they'll want to create a throttling issue or something.
VeraZab
approved these changes
Dec 30, 2017
|
yup, looks good 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an onPurge callback to the component. Currently this component calls
plotly.purge(gd)when unmounting which strips thegraphDivof data, layout, _fullData and _fullLayout. This hook allows applications to take corrective action like transferring these objects to a new object.