Skip to content

use precompiled plotly #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2018
Merged

use precompiled plotly #56

merged 1 commit into from
Mar 7, 2018

Conversation

nicolaskruchten
Copy link
Contributor

If we use a precompiled plotly here we can save users a ton of webpack headaches and make this out-of-the-box compatible with create-react-app.

bpostlethwaite
bpostlethwaite approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Do any documentation changes need to happen?

@nicolaskruchten nicolaskruchten merged commit f437fd7 into master Mar 7, 2018
@nicolaskruchten nicolaskruchten deleted the usedist branch March 7, 2018 14:58
@nicolaskruchten nicolaskruchten restored the usedist branch May 2, 2018 17:03
@nicolaskruchten nicolaskruchten deleted the usedist branch May 2, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaskruchten @bpostlethwaite