Skip to content

Update logging for auth plugin #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Update logging for auth plugin #7

merged 4 commits into from
Jun 10, 2025

Conversation

tarzzz
Copy link

@tarzzz tarzzz commented Jun 10, 2025

Summary

This PR enhances the logging functionality in the auth plugin to improve debugging and monitoring capabilities for the git-ssh-server.

Related Issues

@BRONSOLO Please review when you have a chance.

@tarzzz tarzzz requested a review from BRONSOLO June 10, 2025 16:17
Copy link
Member

@BRONSOLO BRONSOLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this suppress any errors that would be meaningful for the ssh-er to receive? Like if a workspace deploy via ssh fails, would it do so silently now?

@tarzzz
Copy link
Author

tarzzz commented Jun 10, 2025

@BRONSOLO No, I tried that and as a non-licensed user, I get this:

image

and this in container logs:

image

so fwiw, it's better than what we had so far. Both the "Authentication" and Authorization errors show up in container logs and Authorization error show up in frontend.

authentication here refers to the auth-plugin..

@BRONSOLO
Copy link
Member

Oh nice! so it gives us more control even. That rocks. 🚀

Copy link
Member

@BRONSOLO BRONSOLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tarzzz tarzzz merged commit ef80752 into main Jun 10, 2025
@tarzzz tarzzz deleted the add-logging-58 branch June 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants