Skip to content

correctly plit bitmap #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

elwerene
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   66.24%   67.12%   +0.87%     
==========================================
  Files          53       53              
  Lines        5134     5122      -12     
==========================================
+ Hits         3401     3438      +37     
+ Misses       1733     1684      -49     
Impacted Files Coverage Δ
src/drawing/backend.rs 61.17% <0.00%> (+2.35%) ⬆️
src/chart/builder.rs 82.31% <0.00%> (+0.49%) ⬆️
src/chart/context.rs 78.66% <0.00%> (+0.66%) ⬆️
src/coord/datetime.rs 81.22% <0.00%> (+0.74%) ⬆️
src/coord/ranged.rs 43.47% <0.00%> (+1.08%) ⬆️
src/drawing/backend_impl/cairo.rs 89.74% <0.00%> (+1.46%) ⬆️
src/drawing/backend_impl/bitmap.rs 84.84% <0.00%> (+1.78%) ⬆️
src/style/size.rs 78.00% <0.00%> (+2.00%) ⬆️
src/drawing/backend_impl/svg.rs 75.79% <0.00%> (+2.31%) ⬆️
src/style/font/font_desc.rs 50.00% <0.00%> (+2.32%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf3bfd...8ed8649. Read the comment docs.

Copy link
Member

@38 38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch this part isn't tested actually, since svg and bitmap backend implements their own blit function. But this is something we should do. - Thanks so much for the contribution and sorry for the delay.

@38 38 merged commit 4357b0c into plotters-rs:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants