Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parentheses in Sankey node ids break link colors #1150

Closed
JonathanPicques opened this issue Oct 8, 2020 · 3 comments · Fixed by #1152
Closed

Parentheses in Sankey node ids break link colors #1150

JonathanPicques opened this issue Oct 8, 2020 · 3 comments · Fixed by #1152
Labels
bug sankey @nivo/sankey package

Comments

@JonathanPicques
Copy link
Contributor

Describe/explain the bug
Using parentheses in Sankey node ids break links colors (almost identical to #623)

To Reproduce
https://codesandbox.io/s/awesome-sunset-kkhyn

Steps to reproduce the behavior:

  1. Remove parentheses line 20, 25 & 26: the colors work
  2. Add back parentheses line 20, 25 & 26: the colors won't work anymore

Expected behavior
Custom colors should continue to render even when using parentheses in ids

Screenshots
Working without parentheses
image
Broken with parentheses
image

@wyze wyze added bug sankey @nivo/sankey package labels Oct 8, 2020
@wyze
Copy link
Contributor

wyze commented Oct 8, 2020

Feel free to send a PR if you would like!

@JonathanPicques
Copy link
Contributor Author

JonathanPicques commented Oct 9, 2020

@wyze would love too! is there somewhere a guide to start contributing? never used lerna/storybook so I'm a bit lost

@wyze
Copy link
Contributor

wyze commented Oct 9, 2020

We have the https://github.com/plouc/nivo/blob/master/CONTRIBUTING.md you can follow, but it should be a few steps to get started. Clone/fork the repo, then run make init then grab a coffee, hah!, then make storybook and it will launch storybook in dev mode. Then feel free to make your changes and Storybook should reflect them automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sankey @nivo/sankey package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants