Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): change points ordering on stacked lines #1060

Merged
merged 3 commits into from
Jul 31, 2020

Conversation

phacks
Copy link
Contributor

@phacks phacks commented Jul 15, 2020

Fixes #1051

Reversing the lines and points array makes the lines and points belonging to lower series appear on top—and makes the graph less misleading.

See this before/after screenshot comparison (the area of interest is the red and yellow lines at the NG and LS ticks):

Before

image
We get the impression that the yellow line is increasing, although its value is 0.

After

image
We get the right impression (the red line is increasing).

The snapshot diffs are simply a reversing of the position
of line graphs points
@phacks
Copy link
Contributor Author

phacks commented Jul 31, 2020

@wyze Hello! Just checking in to see whether you had time to check this PR out. No worries if not, and please let me know if you need anything else to make reviewing it easier!

@wyze wyze changed the title 1051 fix points ordering stacked lines fix(line): change points ordering on stacked lines Jul 31, 2020
@wyze wyze merged commit c10edbf into plouc:master Jul 31, 2020
@phacks phacks deleted the 1051-fix-points-ordering-stacked-lines branch October 26, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading points displayed in stacked line chart if some values are zero
2 participants