fix(line): change points ordering on stacked lines #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snapshot diffs are simply a reversing of the position of line graphs points
|
@wyze Hello! Just checking in to see whether you had time to check this PR out. No worries if not, and please let me know if you need anything else to make reviewing it easier! |
wyze
approved these changes
Jul 31, 2020
wyze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1051
Reversing the
linesandpointsarray makes the lines and points belonging to lower series appear on top—and makes the graph less misleading.See this before/after screenshot comparison (the area of interest is the red and yellow lines at the NG and LS ticks):
Before
We get the impression that the yellow line is increasing, although its value is 0.
After
We get the right impression (the red line is increasing).