Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generators): add network data generation #1082

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

wyze
Copy link
Contributor

@wyze wyze commented Aug 4, 2020

Moves this from the website workspace so it can be shared with storybook.

Copy link
Contributor

@tg970 tg970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyze, this looks good. Thinking at some point soon we'll want to add some tests to the Network package - I can work on that.

Is there a way we can build and deploy these changes so I can use an updated version of the network in a separate project? It would be great to have access to these changes and PR #1080 in my prod env.

@wyze wyze merged commit 46bf12c into master Aug 5, 2020
@wyze wyze deleted the generators-network branch August 5, 2020 18:40
@wyze
Copy link
Contributor Author

wyze commented Aug 5, 2020

@tg970 Unfortunately I can't cut releases, only merge PRs. @plouc is the only one with the keys to release currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants