feat(scales): Add support for symlog scale #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is heavily inspired by logScale but it is missing the zero and mixed sign calculations as symmetric logarithmic scale supports both.
wyze
suggested changes
Sep 14, 2020
wyze
approved these changes
Sep 14, 2020
|
Thank you Neil! 25 snapshot failures from CI, but looks like that the master branch is failing as well so probably unrelated to this PR. |
|
Yup. I have that fixed in #1128. Thanks for the contribution. We will get this out in the next release, which will hopefully be soon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great library!
Lately we needed to render some graphs using logarithmic scale, but found out that
d3-scale's logarithmic scale is not very well suited for data having a wider range. For those use cases one can use symlog scale which "offers a bi-symmetric log transformation, suitable ‘for wide-range data’. Its domain can span several orders of magnitude, with negative as well as positive values."d3-scalehas also API for that.Add support for symlog scale. The code is heavily inspired by a PR adding the support for logarithmic scale: #378
Compared to logarithmic scale PR, no safe-guarding for zero or negative values is needed since the scale accepts both.
I added relevant stories to storybook but did not include links to website as I thought it's rather similar to logarithmic scale. Users browsing the storybook should find it easily though.
Here is a screenshot of a scatterplot using symlog scale:
Thank you in advance, and let me know if you have any suggestions for improvement.