fix(scatterplot): Support DerivedNodeProp for nodeSize prop #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsiveScatterPlot Adds support for DerivedNodeProp<number> so when a function is passed to nodeSize the id of the node can be referenced. The current implementation uses only DerivedDatumProp<number> and the Datum type only has x and y fields where as Node also contains its id. Also, the nivo docs at https://nivo.rocks/scatterplot/ specify "it will receive the current node and must return a number" which is consistent with the proposed type.
wyze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for DerivedNodeProp so when a function is passed to nodeSize the id of the node can be referenced. The current implementation uses only DerivedDatumProp and the Datum type only has x and y fields where as Node also contains its id.
Also, the nivo docs at https://nivo.rocks/scatterplot/ specify "it will receive the current node and must return a number" which is consistent with the proposed type.