fix(bar): add new prop valueScale to BarCanvas #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds the default values for the Bar chart. This fixes plouc#1273
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d464e2d:
|
|
The documentation is fixed https://1xlzr.sse.codesandbox.io/bar/canvas/ |
wyze
changed the title
ddavydov
pushed a commit
to netronixgroup/nivo
that referenced
this pull request
Apr 8, 2021
Also adds the default values for the Bar chart. This fixes plouc#1273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueScaleprop has been added to the SVG Bar but not to the canvas version. This PR adds the prop and the default values.This fixes #1273.
CC @wyze