Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix invalid core types #1386

Merged
merged 6 commits into from Apr 23, 2021
Merged

fix(core): fix invalid core types #1386

merged 6 commits into from Apr 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2021

Noticed some of the types in core were causing problems for anyone with skipLibCheck: false (the default value). Let me know if the reason for any change isn't clear, I've kept each kind of change in separate commit and a brief summary below.

  • Cannot nest declare statements. Just removing the keyword should be fine
  • Can't inline type alias in const declaration
  • Accessor definition assumed all strings exist as properties on T
  • referenced type OpaqueInterpolation doesn't exist, replaced per d3 types

Callum Mellor-Reed added 5 commits January 14, 2021 12:25
doesn't look like OpaqueInterpolation has been around for a while
replaced with Interpolation, per the return type of useAnimatePath and
the associated d3-interpolate annotations
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 351d7b0:

Sandbox Source
nivo Configuration
nivo-website Configuration

@mrmartineau mrmartineau mentioned this pull request Mar 31, 2021
@mrmartineau
Copy link

@callum-mellorreed-privitar can you confirm if this PR fixes the issues mentioned in #1457?

Also, @plouc is there any reason why this PR might not be reviewed?

@ghost
Copy link
Author

ghost commented Apr 7, 2021

@callum-mellorreed-privitar can you confirm if this PR fixes the issues mentioned in #1457?

Assuming the relevant files haven't changed/expanded since, yeah this is to fix the issues shown in #1457. IIRC I just chucked these in my own declaration file to override the nivo ones as this PR hasn't been acknowledged.

@nostalgiaz
Copy link

@plouc any news related to this merge?

@cpelican
Copy link

We could really use this fix as well! Any idea if it could be merged? Thanks!

@wyze wyze changed the title Fix invalid core types fix(core): fix invalid core types Apr 23, 2021
@wyze wyze merged commit 296f5d1 into plouc:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants