fix(core): fix invalid core types #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 14, 2021 12:25
doesn't look like OpaqueInterpolation has been around for a while replaced with Interpolation, per the return type of useAnimatePath and the associated d3-interpolate annotations
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 351d7b0:
|
Closed
Assuming the relevant files haven't changed/expanded since, yeah this is to fix the issues shown in #1457. IIRC I just chucked these in my own declaration file to override the nivo ones as this PR hasn't been acknowledged. |
|
@plouc any news related to this merge? |
|
We could really use this fix as well! Any idea if it could be merged? Thanks! |
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some of the types in core were causing problems for anyone with
skipLibCheck: false(the default value). Let me know if the reason for any change isn't clear, I've kept each kind of change in separate commit and a brief summary below.declarestatements. Just removing the keyword should be fineOpaqueInterpolationdoesn't exist, replaced per d3 types