Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@nivo/parallel-coordinates next #2329

Merged
merged 12 commits into from May 11, 2023
Merged

@nivo/parallel-coordinates next #2329

merged 12 commits into from May 11, 2023

Conversation

plouc
Copy link
Owner

@plouc plouc commented May 8, 2023 •
edited

Adjust @nivo/parallel-coordinates to be more in line with other packages.

🧰 Internal

  • Migrate the package to TypeScript, so typings should now be correct.

🎉 Improvements

  • Components now support aria attributes.
  • SVG and canvas implementations now support layers.
  • Introduce a testIdPrefix property, if specified, we're going to add a data-test-id attribute to the ParallelCoordinates components, to ease testing. Please note that it doesn't work for ParallelCoordinatesCanvas as it has no concrete elements.
  • The package won't rely on recompose anymore, it was indirectly using it via the withContainer hoc (related to Tracking issue for removing recompose dependency #884).
  • Add support for legends.
  • Introduce a new forwardLegendData property, allowing users to implement custom legends.
  • Add support for data grouping via groupBy and groups.
  • Add support for a custom tooltip.
  • Add unit tests 😅
  • Add stories for the package.

💥 Breaking Changes 😢 (but still improvements for most of them 😄):

  • As suggested in Use readonly types for arrays where appropriate #2248, data & variables are now readonly.
  • axesPlan was removed, we can achieve the same result by using layers now.
  • We now strictly support quantitative values, supporting ordinal data in such a chart didn't really make sense as we cannot compare the features otherwise.

@plouc plouc added typescript parallel-coordinates @nivo/parallel-coordinates package labels May 8, 2023
@plouc plouc self-assigned this May 8, 2023
@vercel
Copy link

vercel bot commented May 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 10:16am

@plouc plouc force-pushed the parallel-coordinates-next branch from 85d307a to 13dcc7a Compare May 8, 2023 11:39
@plouc plouc added this to In progress in TypeScript migration May 8, 2023
@plouc plouc mentioned this pull request May 8, 2023
Closed
11 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 8, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 564f41e:

Sandbox Source
nivo Configuration

@plouc plouc force-pushed the parallel-coordinates-next branch from 8f804bc to 96b2c67 Compare May 8, 2023 13:28
@plouc
feat(parallel-coords): add the ability to forward legend data to allo…
f89b820 
…w implementing custom legends outside of the chart
@plouc plouc changed the title Migrate @nivo/parallel-coordinates @nivo/parallel-coordinates next May 10, 2023
@plouc plouc marked this pull request as ready for review May 10, 2023 11:33
@plouc plouc merged commit ce598c0 into master May 11, 2023
3 of 5 checks passed
@plouc plouc deleted the parallel-coordinates-next branch May 11, 2023 10:12
@plouc plouc moved this from In progress to Done in TypeScript migration May 11, 2023
sebald pushed a commit to sebald/pattern-analyzer that referenced this pull request Dec 22, 2023
@renovate
chore(deps): update nivo monorepo to v0.84.0 (#365)
c5337b9 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@nivo/axes](https://togithub.com/plouc/nivo)
([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/axes)) |
[`0.83.0` ->
`0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2faxes/0.83.0/0.84.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2faxes/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2faxes/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2faxes/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2faxes/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [@nivo/bar](https://togithub.com/plouc/nivo)
([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/bar)) |
[`0.83.0` ->
`0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fbar/0.83.0/0.84.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fbar/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fbar/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fbar/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fbar/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [@nivo/core](https://togithub.com/plouc/nivo)
([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/core)) |
[`0.83.0` ->
`0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fcore/0.83.0/0.84.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fcore/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fcore/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fcore/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fcore/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [@nivo/line](https://togithub.com/plouc/nivo)
([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/line)) |
[`0.83.0` ->
`0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fline/0.83.0/0.84.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fline/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fline/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fline/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fline/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [@nivo/pie](https://togithub.com/plouc/nivo)
([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/pie)) |
[`0.83.0` ->
`0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fpie/0.83.0/0.84.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fpie/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fpie/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fpie/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fpie/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>plouc/nivo (@&#8203;nivo/axes)</summary>

### [`v0.84.0`](https://togithub.com/plouc/nivo/releases/tag/v0.84.0)

[Compare
Source](https://togithub.com/plouc/nivo/compare/v0.83.1...v0.84.0)

##### What's Changed

- fix(bar): use readonly arrays for props as the library does not modif…
by [@&#8203;pcorpet](https://togithub.com/pcorpet) in
[plouc/nivo#2377
- fix(pie): use readonly arrays for props as the library does not modif…
by [@&#8203;pcorpet](https://togithub.com/pcorpet) in
[plouc/nivo#2431
- Fix Bar SSR by
[@&#8203;OleksandrRakovets](https://togithub.com/OleksandrRakovets) in
[plouc/nivo#2464
- Pie: Add the ability to programmatically control the activeId by
[@&#8203;plouc](https://togithub.com/plouc) in
[plouc/nivo#2465

##### New Contributors

- [@&#8203;pcorpet](https://togithub.com/pcorpet) made their first
contribution in
[plouc/nivo#2377
- [@&#8203;OleksandrRakovets](https://togithub.com/OleksandrRakovets)
made their first contribution in
[plouc/nivo#2464

**Full Changelog**:
plouc/nivo@v0.83.1...v0.84.0

### [`v0.83.1`](https://togithub.com/plouc/nivo/releases/tag/v0.83.1)

[Compare
Source](https://togithub.com/plouc/nivo/compare/v0.83.0...v0.83.1)

##### What's Changed

-
[@&#8203;nivo/parallel-coordinates](https://togithub.com/nivo/parallel-coordinates)
next by [@&#8203;plouc](https://togithub.com/plouc) in
[plouc/nivo#2329
- Add tests for gradients attribute by
[@&#8203;hyjoong](https://togithub.com/hyjoong) in
[plouc/nivo#2338
- fix: Lodash - use module imports by
[@&#8203;vio](https://togithub.com/vio) in
[plouc/nivo#2349
- Resolved BoxPlot types not being included in build output by
[@&#8203;NicolasNewman](https://togithub.com/NicolasNewman) in
[plouc/nivo#2351
- Fix website component search by
[@&#8203;aautem](https://togithub.com/aautem) in
[plouc/nivo#2371
- fix: waffle types missing from dist by
[@&#8203;brammitch](https://togithub.com/brammitch) in
[plouc/nivo#2375
- Fix arcLinkLabelsOffset for pie chart by
[@&#8203;aautem](https://togithub.com/aautem) in
[plouc/nivo#2369
- feat/export responsive bar props TypeScript types by
[@&#8203;ollwenjones](https://togithub.com/ollwenjones) in
[plouc/nivo#2396
- fix(stream): fix stream diagram overflowing by
[@&#8203;baldulin](https://togithub.com/baldulin) in
[plouc/nivo#2392
- fix GitHub workflow badge URL by
[@&#8203;shoito](https://togithub.com/shoito) in
[plouc/nivo#2453
- Fix failing builds by [@&#8203;plouc](https://togithub.com/plouc) in
[plouc/nivo#2460
- shiftArray in calendar/src/compute/timeRange.ts should not mutate its
argument by [@&#8203;wirhabenzeit](https://togithub.com/wirhabenzeit) in
[plouc/nivo#2420
- fix(core): upgrade d3-interpolate and d3-scale-chromatic by
[@&#8203;plouc](https://togithub.com/plouc) in
[plouc/nivo#2461
- Feature/bar chart truncate axes ticks by
[@&#8203;SebasQuirogaUCP](https://togithub.com/SebasQuirogaUCP) in
[plouc/nivo#2405
- feat(legends): export SymbolProps by
[@&#8203;plouc](https://togithub.com/plouc) in
[plouc/nivo#2462

##### New Contributors

- [@&#8203;hyjoong](https://togithub.com/hyjoong) made their first
contribution in
[plouc/nivo#2338
- [@&#8203;vio](https://togithub.com/vio) made their first contribution
in
[plouc/nivo#2349
- [@&#8203;NicolasNewman](https://togithub.com/NicolasNewman) made their
first contribution in
[plouc/nivo#2351
- [@&#8203;aautem](https://togithub.com/aautem) made their first
contribution in
[plouc/nivo#2371
- [@&#8203;baldulin](https://togithub.com/baldulin) made their first
contribution in
[plouc/nivo#2392
- [@&#8203;shoito](https://togithub.com/shoito) made their first
contribution in
[plouc/nivo#2453
- [@&#8203;wirhabenzeit](https://togithub.com/wirhabenzeit) made their
first contribution in
[plouc/nivo#2420
- [@&#8203;SebasQuirogaUCP](https://togithub.com/SebasQuirogaUCP) made
their first contribution in
[plouc/nivo#2405

**Full Changelog**:
plouc/nivo@v0.83.0...v0.83.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the
month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/sebald/pattern-analyzer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@MethSarcus MethSarcus mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@plouc plouc

Labels
parallel-coordinates @nivo/parallel-coordinates package typescript
Projects
TypeScript migration
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate @nivo/parallel-coordinates to TypeScript
1 participant
@plouc