Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): prop to format values in tooltip was added #69

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

ahtohbi4
Copy link
Contributor

@plouc property to format values in tooltip was added for components Bar, Bubble, Chord, HeatMap, Line, Pie, Radar, Sankey and Stream.

@plouc
Copy link
Owner

plouc commented Oct 17, 2017

@ahtohbi4, thank you for this nice addition!
Just 2 suggestions:

  • It could be nice to have the same logic as other formatting related properties, supporting d3.format or custom function
  • I tend to prefer flat properties (appart from specific configs such as axes) because it's easier to diff those, so in this case tooltipFormat

@ahtohbi4
Copy link
Contributor Author

ahtohbi4 commented Oct 25, 2017

@plouc, everything was fixed.

@plouc
Copy link
Owner

plouc commented Oct 26, 2017

@ahtohbi4, thank you, and you updated the stories 👍

@plouc plouc merged commit 0dfafff into plouc:master Oct 26, 2017
@plouc
Copy link
Owner

plouc commented Oct 26, 2017

I cannot release it for now, will try to do it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants