Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scales): fix timeScale min/max values and typings #743

Merged
merged 2 commits into from
May 16, 2020
Merged

fix(scales): fix timeScale min/max values and typings #743

merged 2 commits into from
May 16, 2020

Conversation

grogi
Copy link
Contributor

@grogi grogi commented Nov 10, 2019 •
edited
Loading

  • updated the TypeScript definition to allow for min and max properties in the TimeScale
  • updated the implementation to behave correctly with custom min/max values when the TimeScale has format property specified.

@grogi
Support for min/max in the TimeScale.
2369794
@grogi
Min/max take same format as input data
31fac9c 
If the input data is formatted and the format property of the scale is set - exp. '%Y-%m-%d' - the min/max properties provided explicitly were not taken into account. Instead the actual range was used - this was crashing as the values `values.max` and `values.min` are already converted to native format.
@grogi
Copy link
Contributor Author

grogi commented Nov 10, 2019

Pull request #734 is a subset of this one.

@wyze wyze changed the title Fixes for the TimeScale fix(scales): fix timeScale min/max values and typings May 16, 2020
@wyze wyze merged commit bcb4516 into plouc:master May 16, 2020
@wyze wyze mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grogi @wyze