feat(sunburst): add mouse events and some labels #880
Conversation
…mouseleave events
…ve the same as Pie slices labels
|
What's holding this from being merged? |
|
Thank you @juliankrieger! The build is failing, do you think you could you have a look? |
|
Yes @plouc , the build fails because of |
fix 'centerRadius' is constant no-const-assign test
|
@plouc Build is successful |
| @@ -8,6 +8,7 @@ | |||
| */ | |||
| import React from 'react' | |||
| import PropTypes from 'prop-types' | |||
| import { noop } from '@nivo/core' | |||
There was a problem hiding this comment.
This should be with the other imports from @nivo/core.
| export default class SunburstLabels extends Component { | ||
| static propTypes = { | ||
| nodes: PropTypes.arrayOf(PropTypes.shape({})).isRequired, | ||
| label: PropTypes.oneOfType([PropTypes.string, PropTypes.func]), |
There was a problem hiding this comment.
Should be updated to just a func and be required, based on usage below.
|
I am knee deep in my thesis, maybe after I am done with it. |
|
Does anyone have an update on the status of this pr? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 907f4d5:
|
wyze
changed the title
|
Thanks everyone for all the work on this and sorry about the long delay on merging! |
- Add slice labels at the first level - Add onClick/onMouseEnter/onMouseLeave events Co-authored-by: Manuele J Sarfatti <mjsarfatti@gmail.com> Co-authored-by: Julian Krieger <julian.krieger@ergosign.de> Co-authored-by: Asma Berkani <asma.berkani@outlook.com> Co-authored-by: Neil Kistner <neil.kistner@gmail.com>
Because of @mjsarfatti 's absence, I have continued to implement what you recommended @plouc.
Please review the changes and tell me what you think