Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scatterplot): fix serieId typing #886

Merged
merged 1 commit into from
May 16, 2020

Conversation

stuartlong
Copy link
Contributor

serieId is a property on Node.data not Node itself:
From compute.js

export const computePoints = ({ series, formatX, formatY }) => {
    return series.reduce(
        (agg, serie) => [
            ...,
            ...serie.data.map((d, i) => ({
               ...,
                data: {
                    ...,
                    serieId: serie.id
                },
            })),
        ],
        []
    )
}

@stuartlong stuartlong changed the title Fix serie ID typing [ScatterPlot] Fix serie ID typing Mar 3, 2020
@stuartlong stuartlong closed this Mar 3, 2020
@stuartlong stuartlong reopened this Mar 3, 2020
@wyze wyze changed the title [ScatterPlot] Fix serie ID typing fix(scatterplot): fix serieId typing May 16, 2020
@wyze wyze merged commit ef1ee4c into plouc:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants