Skip to content

Generalize source object #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

Generalize source object #61

wants to merge 23 commits into from

Conversation

btry
Copy link
Collaborator

@btry btry commented Sep 19, 2025 •
edited
Loading

Rename from CarbonIntensitySource to Source to manage sources related to other aspects of LCA.

Done:

  • update the diagnosis algorithm to use the up to date relation

TODO:

  • migrate location / zone relation from text to object
  • inherit association location / zone from ancestors of current location

@btry btry changed the base branch from develop to support/1.1.0 September 19, 2025 11:47
@btry btry changed the base branch from support/1.1.0 to develop September 19, 2025 11:48
@btry btry force-pushed the refactor/generalize_source branch from 82979d1 to f871f0c Compare September 19, 2025 12:07
@btry btry changed the base branch from develop to support/1.1.0 September 19, 2025 12:09
@btry btry changed the base branch from support/1.1.0 to develop September 19, 2025 12:09
@btry btry force-pushed the refactor/generalize_source branch 2 times, most recently from a13dfe9 to 9c87e79 Compare September 19, 2025 13:03
@btry btry force-pushed the refactor/generalize_source branch 2 times, most recently from 4cea583 to 2a7edb5 Compare October 3, 2025 16:46
@btry btry marked this pull request as draft October 3, 2025 16:48
@btry btry force-pushed the refactor/generalize_source branch 2 times, most recently from 28ca384 to 250d85c Compare October 6, 2025 07:59
@btry btry mentioned this pull request Oct 9, 2025
Open
@btry btry force-pushed the refactor/generalize_source branch from ee9224d to 7bdf65a Compare October 13, 2025 08:04
btry added 14 commits October 13, 2025 15:22
@btry
refactor(CarbonIntensitySource): rename object to Source
536ad65 
Impacts CarbonIntensityZource_Zone, which has been renamed
Semantically unlocks the abolity to use Source object to store data for data sources other than carbon intensity
@btry
feat(Location): move plugin specific field for location to a tab
c7e0ab8
@btry
fix(ComputerType,MonitorType): more conststent right checks
42485e6
@btry
feat(Location): associate location to a carbon intensity zone
465d819
@btry
style(Impact\History\AbstractAsset): code cleanup
46340a1
@btry
fix(Impact\History\AbstractAsset): test memory before calculating a c…
532f3ca 
…arbon emission

A result was calculated but not saved, wasting computational resources
@btry
test: replace deprecated methods
a2cefa3
@btry
refactor(Zone): set alias to location class
74f1772
@btry
feat(Zone): update algorithms to find zone from location or asset
1174bd2
@btry
test(Install): add message on failure
fcd54a9
@btry
tst(Location): fix test method name
33e814d
@btry
test(Impact\History\Monitor): update out of date itemtype
d2a5926
@btry
test: update tests with location /zone relation
1e67bca
@btry
feat(Location): associate location to a carbon intensity zone
6f485d7
@btry btry force-pushed the refactor/generalize_source branch 6 times, most recently from 41fb389 to 8d621a9 Compare October 14, 2025 07:30
@btry btry force-pushed the refactor/generalize_source branch from 8d621a9 to 8c87121 Compare October 14, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@btry