Skip to content

Fix(Core): update classname generation method #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(Core): update classname generation method #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,19 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.22.0] - 2025-09-30

### Added

- GLPI 11 compatibility
## [UNRELEASED]

### Fixed

- Fix `massive action` for adding value to `multiple` dropdown fields
- Fix for the `COALESCE` part of the `SQL query` for `multiple` dropdowns
- Fix `search option` for `multiple` dropdown
- Fix display from Planning view
- Fix `classname` resolution when multiple `s` at end of container name

## [1.22.0] - 2025-09-30

### Added

- GLPI 11 compatibility

## [1.21.23] - 2025-08-26

### Fixed
Expand Down
3 changes: 1 addition & 2 deletions inc/container.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,7 @@ public static function preItemPurge($item)
foreach ($founded_containers as $container) {
$itemtypes = json_decode($container['itemtypes']);
if (in_array($itemtype, $itemtypes)) {
$classname = 'PluginFields' . $itemtype . getSingular($container['name']);
$classname = preg_replace('/s{2}$/i', 's', $classname); // in case name ends with 'ss' remove last 's'
$classname = self::getClassname($itemtype, $container['name']);
$fields = new $classname();
$fields->deleteByCriteria(['items_id' => $item->fields['id']], true);
}
Expand Down