Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View.tsx does not respect "manual" attribute of Orthographic camera. #1966

Closed
talkingtab opened this issue May 29, 2024 · 3 comments
Closed
Labels
bug Something isn't working Stale Inactive issue

Comments

@talkingtab
Copy link

Line 88.

see also #515
see also #1562

What a hydra!

@talkingtab talkingtab added the bug Something isn't working label May 29, 2024
@talkingtab
Copy link
Author

Setting a custom frustum in an OrthographicCamera is fragile. Setting {manual: true} is required. You also have to ensure that left right, top bottom are passed the right way - not args[]. Then there are issues of updating cameras and ensuring new code does not just assume that the right thing is just update on size.

I can think of strategies:
if {rltb} is passed in, automatically mark it as 'manual'
invert the sense, assume "manual" but pass in "dynamic" :-)
or maybe best, require some flag to be set like {policy='manual'}
I'm not sure these are really good idea or suggestions, but it would be nice to avoid users running into this and coders updating based on size.

Copy link

Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward.

Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar.

Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project!

@github-actions github-actions bot added the Stale Inactive issue label Oct 30, 2024
Copy link

github-actions bot commented Nov 7, 2024

We’re closing this issue to keep our project manageable and make room for other active work, but we truly appreciate your effort and contribution.

If you’d like to continue working on this, please feel free to re-open it or reach out on Discord — our community is always ready to support you. Thanks again for helping us stay organized and for understanding our approach!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale Inactive issue
Projects
None yet
Development

No branches or pull requests

1 participant