Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bounding sphere to grass shader demo #82

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

isaac-mason
Copy link
Member

@abernier
Copy link
Member

hey @isaac-mason thx, is it ready for merge?

@hichemfantar
Copy link

Thanks for the pr! I'll test and report back asap

@hichemfantar
Copy link

hichemfantar commented Aug 26, 2024

The bug seems to be fixed!
I have a question, is there any performance impact with adding a bounding sphere?
Also the entire grass shader example seems to have performance pitfalls according to this thread.
Do you agree that we should update the implementation?

@abernier abernier merged commit 1a56185 into pmndrs:main Aug 26, 2024
2 checks passed
@hichemfantar hichemfantar mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants