feat(build): only exports vanilla in React Server Component

[himself65]

Related Issues or Discussions

Revert: #2245

Fixes: #2269

Summary

Only exports vanilla files in react server condition when importing jotai.

This behavior will be similar to swr(https://github.com/vercel/swr/blob/main/core/src/index.react-server.ts). Like they only exports few function when react server

Check List

• yarn run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2023 0:07am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 142ba5b:

Sandbox	Source
React	Configuration
React TypeScript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
Next.js	Configuration
Next.js with custom Babel config	Configuration
React with custom Babel config	Configuration

[himself65]

I go through the code, and all react* files uses or useAtom which is not accepted in react server environment

[dai-shi]

While this might improve the RSC developer experience, I don't think it solves #2241.

At this point, I don't think adding react-server entry point to show an error is necessary. React should be showing errors anyway. Or, we can add client-only if we want an explicit error.

If we don't have a solution with 'use client', let's revert #2245.

[himself65]

While this might improve the RSC developer experience, I don't think it solves #2241.

At this point, I don't think adding react-server entry point to show an error is necessary. React should be showing errors anyway. Or, we can add client-only if we want an explicit error.

If we don't have a solution with 'use client', let's revert #2245.

revert would be better

[himself65]

There might be another approach. We have index.react-server.ts that only exports vanilla.ts.

This might help if people did import jotai but only used atom. Otherwise, they have to import jotai/vanilla, which might be a little complicated because I have to check all of the files, like when I transfer some demos to next.js that only uses atom

[himself65]

I made some changes, reopening...

[dai-shi]

Unfortunately, it doesn't change my previous comment. I feel it's worse because it hides the error.

Otherwise, they have to import jotai/vanilla,

That's recommended. So, it's a doc issue.