Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jotai/query (powered by react-query) #248

Merged
merged 45 commits into from
Feb 19, 2021
Merged

feat: jotai/query (powered by react-query) #248

merged 45 commits into from
Feb 19, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 31, 2020

This is to add new lib jotai/query with react-query.

  • atomWithQuery implementation
  • tests
  • docs
  • examples

Note this PR is for the basic use case. It doesn't cover advanced use cases including mutation.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06b4236:

Sandbox Source
React Configuration
React Typescript Configuration

@Aslemammad
Copy link
Member

I'm gonna work on it, thanks for the help.

This was referenced Jan 18, 2021
@dai-shi dai-shi marked this pull request as draft January 19, 2021 15:20
@dai-shi dai-shi marked this pull request as ready for review February 15, 2021 15:33
@dai-shi
Copy link
Member Author

dai-shi commented Feb 17, 2021

We still have the loading issue: https://codesandbox.io/s/jotai-query-demo-forked-k3t5h?file=/src/App.tsx

@dai-shi dai-shi changed the title wip: jotai/query with react-query feat: jotai/query (powered by react-query) Feb 18, 2021
@dai-shi dai-shi merged commit df33993 into master Feb 19, 2021
@dai-shi dai-shi deleted the feat/react-query branch February 19, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants