-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update atom value with conditional dependencies (regression with #2363) #2534
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Playground | Link |
---|---|
React demo | https://livecodes.io?x=id/9AHXWMS9P |
See documentations for usage instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it.
Hm, the skipIf
hack doesn't work for build test. Let me see if I can find a better way.
tests/vanilla/dependency.test.tsx
Outdated
store.sub(filteredAtom, () => undefined) | ||
store.sub(stageAtom, () => undefined) | ||
|
||
store.set(dataAtom, [100]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this here, or can use simply initialize the data atom with [100]
?
If we need it here, please add a comment for clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was important, but yeah the test still works without it.
e116852
to
c90a840
Compare
oops, #2535 wasn't enough... hmm, is it really failing? |
Hi @samkline, if you are around, can you check this and see if you can fix |
We need to fix this... |
I did some investigating and I believe the regression involves
My understanding is that |
Nice finding.
I didn't follow everything. So, what's the suggested change? |
Sorry, it was a debugging change I made just for the test case (these lines) to learn whether |
Related Issues or Discussions
Fixes #2532
Summary
Add missing test case for conditional dependents receiving stale values since 59e04ab.
Check List
yarn run prettier
for formatting code and docs