[CI] Build fails because of warnings

[bjornstar]

From the build phase:

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Changing the rules in .eslintrc.json to warn causes the builds to fail. If we want to fix the warnings we can, but it would be nice to revert that change in the meantime.

[drcmda]

I can't work with eslint in error mode as it actively gets in the way. Want to comment out a thing to try something real quick, nope, no unused variables, need to remove every trace of it down to the very Imports. I think it should check before publish imo that's the only place where it makes sense.

[bjornstar]

Yes, I agree. I don't think eslint belongs in the development build process. Typically it's only run locally as a pre-commit hook where it's not in the way of getting work done, but helps ensure committed code is formatted consistently.

The changes made however were to turn some ignored rules into warnings which is causing the build to fail. I'll look into how we can get eslint out of the build phase. How attached to react-scripts are you?