Add Tear constraint example #318
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/use-cannon/6CrKqrLJVz6F8vK9yBxS1wtGiUBC |
|
@bjornstar : I've commented on the code above with questions I'd appreciate your feedback on so I can implement it in a way you're happy with. Hope this helps. Thanks! |
Glavin001
force-pushed
the
feat/constraint-max-multiplier
branch
from
873afcf
to
8c64609
Compare
|
@bjornstar Ready for final review 🎉 |
src/worker.js
Outdated
| @@ -331,12 +332,29 @@ self.onmessage = (e) => { | |||
| } | |||
| constraint.uuid = uuid | |||
| state.world.addConstraint(constraint) | |||
|
|
|||
| if (!isNaN(maxMultiplier)) { | |||
There was a problem hiding this comment.
OK. Would a truthy check be satisfactory?
| if (!isNaN(maxMultiplier)) { | |
| if (maxMultiplier) { |
There was a problem hiding this comment.
The above wouldn't support maxMultiplier being 0, this may be more appropriate:
| if (!isNaN(maxMultiplier)) { | |
| if (maxMultiplier !== undefined) { |
examples/src/demos/Tear.tsx
Outdated
| <spotLight position={[10, 10, 10]} angle={0.3} penumbra={1} intensity={1} castShadow /> | ||
| <Physics gravity={[0, -40, 0]} allowSleep={false}> | ||
| <Handle radius={0.5}> | ||
| <Projectile radius={2.0} /> |
There was a problem hiding this comment.
I don't think the Projectile should be inside of the chain.
There was a problem hiding this comment.
Can do. This was to ensure the Projectile lines up the shot with the Handle and the Chain Links below it.
There was a problem hiding this comment.
Removed projectile entirely in favour of your suggestion:
Can we drag one chain through several other chains that tear?
|
I'd really prefer not to have cross dependencies between demos. The hallmark of demos is that they are a single file that demonstrate a feature. We should be able to take that file put it in a sandbox with minimal setup. If the two are so similar that they share files, they should be in the same file with some form of interaction. Can we drag one chain through several other chains that tear? How about clicking to reset the torn chains? |
Add maxMultipler threshold to constraints. Inspired by https://github.com/pmndrs/cannon-es/blob/6f11e268d5e196f7f4f5908dbf60ae6365bd6ab6/examples/tear.html
Glavin001
force-pushed
the
feat/constraint-max-multiplier
branch
from
8c64609
to
02f8cbf
Compare
|
@bjornstar : Pushed new demo/example and other fixes based on your feedback above. Ready for review again. Thanks! |
|
Cool, I think this turned out quite well. Thanks for the contribution! |
|
Released in v4.5.0 |
|
Thanks for merging, @bjornstar ! Next up is #317 (comment) |
Add maxMultipler threshold to constraints.
Inspired by https://github.com/pmndrs/cannon-es/blob/6f11e268d5e196f7f4f5908dbf60ae6365bd6ab6/examples/tear.html
maxMultiplieroption to all constraints, which disables constraint when threshold is exceededpostSteplistener ifmaxMultiplierset / notundefinedChain)maxMultipliervalues0 = blue/easily break,1500 = red/harder to break,white = undefined/won't break)Demo
https://use-cannon-git-fork-glavin001-feat-constraint-max-e97738-pmndrs.vercel.app/#/demo/Chain
Initially:
After breaking some chain constraints: