Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revisit prettier config to be minimal #2193

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 13, 2023

The prettier config was defined back in some time, and prettier has been updated since then.
I think we should follow the default config as much as possible.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview Nov 13, 2023 2:10am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f1da6a:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@dai-shi
Copy link
Member Author

dai-shi commented Nov 13, 2023

@sandren Can you open a PR for jotai?
@Aslemammad Can you open a PR for valtio?

Copy link

Size Change: 0 B

Total Size: 52.4 kB

ℹ️ View Unchanged
Filename Size
dist/context.js 820 B
dist/esm/context.js 612 B
dist/esm/index.js 717 B
dist/esm/middleware.js 3.87 kB
dist/esm/middleware/immer.js 210 B
dist/esm/react/shallow.js 479 B
dist/esm/shallow.js 511 B
dist/esm/traditional.js 400 B
dist/esm/vanilla.js 629 B
dist/esm/vanilla/shallow.js 366 B
dist/index.js 874 B
dist/middleware.js 4.44 kB
dist/middleware/immer.js 328 B
dist/react/shallow.js 1.07 kB
dist/shallow.js 1.11 kB
dist/system/context.development.js 694 B
dist/system/context.production.js 390 B
dist/system/index.development.js 881 B
dist/system/index.production.js 407 B
dist/system/middleware.development.js 4 kB
dist/system/middleware.production.js 2.62 kB
dist/system/middleware/immer.development.js 292 B
dist/system/middleware/immer.production.js 187 B
dist/system/react/shallow.development.js 577 B
dist/system/react/shallow.production.js 400 B
dist/system/shallow.development.js 559 B
dist/system/shallow.production.js 345 B
dist/system/traditional.development.js 514 B
dist/system/traditional.production.js 348 B
dist/system/vanilla.development.js 672 B
dist/system/vanilla.production.js 310 B
dist/system/vanilla/shallow.development.js 441 B
dist/system/vanilla/shallow.production.js 322 B
dist/traditional.js 443 B
dist/umd/context.development.js 928 B
dist/umd/context.production.js 568 B
dist/umd/index.development.js 1 kB
dist/umd/index.production.js 546 B
dist/umd/middleware.development.js 4.59 kB
dist/umd/middleware.production.js 2.97 kB
dist/umd/middleware/immer.development.js 482 B
dist/umd/middleware/immer.production.js 342 B
dist/umd/react/shallow.development.js 1.21 kB
dist/umd/react/shallow.production.js 895 B
dist/umd/shallow.development.js 1.23 kB
dist/umd/shallow.production.js 883 B
dist/umd/traditional.development.js 625 B
dist/umd/traditional.production.js 452 B
dist/umd/vanilla.development.js 800 B
dist/umd/vanilla.production.js 410 B
dist/umd/vanilla/shallow.development.js 1.1 kB
dist/umd/vanilla/shallow.production.js 849 B
dist/vanilla.js 683 B
dist/vanilla/shallow.js 969 B

compressed-size-action

@Aslemammad
Copy link
Member

Hey @dai-shi, Yes, sure.

@dai-shi dai-shi marked this pull request as ready for review November 14, 2023 03:17
@dai-shi dai-shi merged commit 9857a67 into main Nov 14, 2023
35 checks passed
@dai-shi dai-shi deleted the chore/revisit/prettier-config branch November 14, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants