-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): a workaround for ESM for use-sync-external-store #953
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2157ad:
|
Size Change: +99 B (0%) Total Size: 29.9 kB
ℹ️ View Unchanged
|
Can anyone (as many as possible) try if this works on their environments? https://ci.codesandbox.io/status/pmndrs/zustand/pr/953 |
It doesn't seem a right workaround: pmndrs/valtio#469 |
Or, should we do it? pmndrs/valtio#469 (comment) |
@dai-shi I tried using what was coming from the CodeSandbox, and I'm still having this issue:
|
Do you mean it doesn't happen without this PR? I mean |
It happens also when I use this PR. This PR does not work for me. And it also happens on |
It sounds like a different issue then. Please open a new issue with a reproduction. |
Let's see how it goes. |
This is the same fix as pmndrs/valtio#456, reported in pmndrs/valtio#452.