-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for new potree format #139
Conversation
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
Co-authored-by: Piotr Jurczyński <619650+pjurczynski@users.noreply.github.com>
if (loaded[version]) { | ||
return; | ||
} | ||
loaded[version] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For an example, it would probably feel more natural to check if the url is loaded rater than the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions @turien-pix4d I've updated the unloading accordingly. In terms of checking the url, I personally think we can leave it as is as this is really just meant as an example to show how to load and dump the two different Pointcloud versions.
This PR adds support for the new Potree format 2.0 aka
metadata.json
.It is based to a large extent on this community fork https://github.com/shiukaheng/potree-loader and on https://github.com/tentone/potree-core as well as https://github.com/potree/potree obviously.
Main differences being:
#version 300 es
. If we really need this at some point it should be scope of another PR since all the refactoring clutters the actual update.